Gh0st
/
linux
mirror of https://github.com/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ocfs2: constify struct ocfs2_stack_operations 

"struct ocfs2_stack_operations" are not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

In order to do it, "struct ocfs2_stack_plugin" also needs to be adjusted
to this new const qualifier.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
   6241	    644	      0	   6885	   1ae5	fs/ocfs2/stack_o2cb.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
   6337	    548	      0	   6885	   1ae5	fs/ocfs2/stack_o2cb.o

Link: https://lkml.kernel.org/r/f52dab89ee0049ec6271de29183a781efbb275ab.1718398605.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Joseph Qi <jiangqi903@gmail.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Gang He <ghe@suse.com>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Christophe JAILLET 2024-06-14 22:57:09 +02:00 committed by Andrew Morton
parent 3ebe69c0c3
commit 03bf0044e1
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ocfs2/stack_o2cb.c
View File

@ -404,7 +404,7 @@ static int o2cb_cluster_this_node(struct ocfs2_cluster_connection *conn,
return 0; return 0;
} }
static struct ocfs2_stack_operations o2cb_stack_ops = { static const struct ocfs2_stack_operations o2cb_stack_ops = {
.connect = o2cb_cluster_connect, .connect = o2cb_cluster_connect,
.disconnect = o2cb_cluster_disconnect, .disconnect = o2cb_cluster_disconnect,
.this_node = o2cb_cluster_this_node, .this_node = o2cb_cluster_this_node,

2
fs/ocfs2/stack_user.c
View File

@ -1065,7 +1065,7 @@ static int user_cluster_this_node(struct ocfs2_cluster_connection *conn,
return 0; return 0;
} }
static struct ocfs2_stack_operations ocfs2_user_plugin_ops = { static const struct ocfs2_stack_operations ocfs2_user_plugin_ops = {
.connect = user_cluster_connect, .connect = user_cluster_connect,
.disconnect = user_cluster_disconnect, .disconnect = user_cluster_disconnect,
.this_node = user_cluster_this_node, .this_node = user_cluster_this_node,

2
fs/ocfs2/stackglue.h
View File

@ -223,7 +223,7 @@ struct ocfs2_stack_operations {
*/ */
struct ocfs2_stack_plugin { struct ocfs2_stack_plugin {
char *sp_name; char *sp_name;
struct ocfs2_stack_operations *sp_ops; const struct ocfs2_stack_operations *sp_ops;
struct module *sp_owner; struct module *sp_owner;
/* These are managed by the stackglue code. */ /* These are managed by the stackglue code. */